Bump Terraform provider version to v3.110.0 #825

turkenf · 2024-09-24T08:36:36Z

Description of your changes

In this PR:

Upgraded Terraform provider version to v3.110.0
Added reference configurations to fields that were removed due to the change of examples in the Terraform registry and caused issues during the generate type ShareDirectoryParameters has no field or method ShareNameRef
Added new fields manually to v1beta1 APIs
Made secret name field sensitive for ContainerApp to avoid breaking change.
Fixed example manifests for the resources; KubernetesCluster and SQLFunction

I have:

Read and followed Crossplane's contribution process.
Run make reviewable to ensure this PR is ready for review.
Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Breaking CRD schema changes

package/crds/azurestackhci.azure.upbound.io_clusters.yaml =>

NAME                                             SYNCED   READY   EXTERNAL-NAME   AGE
cluster.azurestackhci.azure.upbound.io/example   True     True    example         150m

package/crds/containerapp.azure.upbound.io_containerapps.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11177307635
package/crds/cosmosdb.azure.upbound.io_sqlcontainers.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11177316095
package/crds/dataprotection.azure.upbound.io_backuppolicyblobstorages.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11129154478
package/crds/machinelearningservices.azure.upbound.io_computeinstances.yaml => Manually

NAME                                                                     SYNCED   READY   EXTERNAL-NAME   AGE
computeinstance.machinelearningservices.azure.upbound.io/exampleci0001   True     True    exampleci0001   32m

package/crds/network.azure.upbound.io_bastionhosts.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11129152319

Native schema version changes

azurerm_app_service_certificate_order => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11133109853
azurerm_application_insights => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11129150004
azurerm_application_insights_api_key => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11129150004
azurerm_application_insights_smart_detection_rule => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11129148599
azurerm_storage_blob_inventory_policy => Manually

NAME                                                       SYNCED   READY   EXTERNAL-NAME
                                                  AGE
blobinventorypolicy.storage.azure.upbound.io/example-bip   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/example-rg-bip/providers/Mi
crosoft.Storage/storageAccounts/examplergb34552   29m

Random Tests

examples/containerservice/v1beta1/kubernetescluster.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11145181372
examples/cdn/v1beta2/endpoint.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11146546720
examples/network/v1beta1/subnet.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11177366602
examples/network/v1beta2/routefilter.yaml => https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11146553723

turkenf · 2024-09-26T13:05:20Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

turkenf · 2024-09-26T13:06:37Z

/test-examples="examples/cosmosdb/v1beta1/sqlfunction.yaml"

turkenf · 2024-09-26T13:07:51Z

/test-examples="examples/dataprotection/v1beta1/backuppolicyblobstorage.yaml"

turkenf · 2024-09-26T13:08:35Z

/test-examples="examples/machinelearningservices/v1beta1/computeinstance.yaml"

turkenf · 2024-09-26T13:09:06Z

/test-examples="examples/network/v1beta1/bastionhost.yaml"

turkenf · 2024-09-26T13:10:30Z

/test-examples="examples/certificateregistration/v1beta1/appservicecertificateorder.yaml"

turkenf · 2024-09-26T13:12:58Z

/test-examples="examples/insights/v1beta1/applicationinsightsapikey.yaml"

turkenf · 2024-09-26T13:13:50Z

/test-examples="examples/insights/v1beta1/applicationinsightssmartdetectionrule.yaml"

turkenf · 2024-09-26T13:19:05Z

/test-examples="examples/network/v1beta1/subnet.yaml"

turkenf · 2024-09-27T19:27:24Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

turkenf · 2024-09-27T20:33:31Z

/test-examples="examples/containerservice/v1beta1/kubernetescluster.yaml"

turkenf · 2024-09-27T21:47:35Z

/test-examples="examples/containerservice/v1beta1/kubernetescluster.yaml"

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-10-01T16:04:16Z

/test-examples="examples/network/v1beta1/subnet.yaml"

turkenf · 2024-10-01T16:04:21Z

/test-examples="examples/insights/v1beta1/applicationinsightssmartdetectionrule.yaml"

turkenf · 2024-10-01T16:04:26Z

/test-examples="examples/insights/v1beta1/applicationinsightsapikey.yaml"

turkenf · 2024-10-01T16:04:30Z

/test-examples="examples/certificateregistration/v1beta1/appservicecertificateorder.yaml"

turkenf · 2024-10-01T16:04:35Z

/test-examples="examples/network/v1beta1/bastionhost.yaml"

turkenf · 2024-10-01T16:04:39Z

/test-examples="examples/machinelearningservices/v1beta1/computeinstance.yaml"

turkenf · 2024-10-01T16:04:44Z

/test-examples="examples/dataprotection/v1beta1/backuppolicyblobstorage.yaml"

turkenf · 2024-10-01T16:04:48Z

/test-examples="examples/cosmosdb/v1beta1/sqlfunction.yaml"

turkenf · 2024-10-01T16:04:54Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

turkenf · 2024-10-01T17:05:17Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-10-01T20:38:54Z

/test-examples="examples/cosmosdb/v1beta1/sqlfunction.yaml"

turkenf · 2024-10-01T20:39:32Z

/test-examples="examples/certificateregistration/v1beta1/appservicecertificateorder.yaml"

turkenf · 2024-10-01T21:01:33Z

/test-examples="examples/machinelearningservices/v1beta1/computeinstance.yaml"

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-10-02T13:25:18Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/11144688742

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-10-02T13:54:51Z

/test-examples="examples/containerservice/v1beta1/kubernetescluster.yaml"

turkenf · 2024-10-02T15:12:36Z

/test-examples="examples/network/v1beta1/subnet.yaml"

turkenf · 2024-10-02T15:13:11Z

/test-examples="examples/cdn/v1beta2/endpoint.yaml"

turkenf · 2024-10-02T15:13:38Z

/test-examples="examples/network/v1beta2/routefilter.yaml"

mergenci

Using my bespoke Go command, I verified that the new 24 singleton list fields were backported successfully. I'll do a few more checks for other fields in the morning and complete my review then. Please see one question I had below.

apis/dataprotection/v1beta1/zz_backuppolicyblobstorage_types.go

Signed-off-by: Cem Mergenci <[email protected]>

mergenci · 2024-10-04T09:15:01Z

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

mergenci · 2024-10-04T09:15:32Z

/test-examples="examples/cosmosdb/v1beta1/sqlfunction.yaml"

mergenci · 2024-10-04T09:18:55Z

/test-examples="examples/network/v1beta1/subnet.yaml"

mergenci

Thanks for your great effort @turkenf 🙏 We still have a lot to do before we could version bump Terraform providers automatically.

I Uptested some of the resources, to InitParameters of which I added SecretRefs. I edited PR description with links to the latest Uptest results.

turkenf force-pushed the bump-tf-3.110.0 branch from 96cf5f4 to 9dc4268 Compare September 24, 2024 11:40

turkenf force-pushed the bump-tf-3.110.0 branch from b46e7b5 to 755afce Compare September 27, 2024 20:33

turkenf added 3 commits September 28, 2024 00:50

Bump Terraform provider version to v3.110.0

5242e8f

Signed-off-by: Fatih Türken <[email protected]>

Add removed refs

da86eb2

Signed-off-by: Fatih Türken <[email protected]>

Run make generate

208458d

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bump-tf-3.110.0 branch 3 times, most recently from 7573b4f to 4ef6af4 Compare October 1, 2024 12:54

Add new fields to v1beta1 apis

270d9c6

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bump-tf-3.110.0 branch from 4ef6af4 to 270d9c6 Compare October 1, 2024 14:55

Add missing resource group to cosmosdb sqlfunction.yaml

13dfad9

Signed-off-by: Fatih Türken <[email protected]>

Make secret name field sensitive for container app

69ce4de

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bump-tf-3.110.0 branch from 5e1ee8e to 69ce4de Compare October 2, 2024 13:19

Change location for KubernetesCluster resource

6755a18

Signed-off-by: Fatih Türken <[email protected]>

turkenf marked this pull request as ready for review October 2, 2024 15:46

turkenf requested review from ulucinar and sergenyalcin as code owners October 2, 2024 15:46

turkenf requested a review from mergenci October 2, 2024 15:56

mergenci reviewed Oct 3, 2024

View reviewed changes

apis/dataprotection/v1beta1/zz_backuppolicyblobstorage_types.go Show resolved Hide resolved

mergenci added 2 commits October 4, 2024 11:58

Backport SecretRefs to InitParameters.

0b33ec9

Signed-off-by: Cem Mergenci <[email protected]>

Run make generate.

361a15b

Signed-off-by: Cem Mergenci <[email protected]>

mergenci approved these changes Oct 4, 2024

View reviewed changes

turkenf merged commit 580e8a4 into crossplane-contrib:main Oct 4, 2024
14 checks passed

turkenf deleted the bump-tf-3.110.0 branch October 4, 2024 11:23

Bump Terraform provider version to v3.110.0 #825

Bump Terraform provider version to v3.110.0 #825

Conversation

turkenf commented Sep 24, 2024 • edited by mergenci Loading

Description of your changes

How has this code been tested

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 26, 2024

turkenf commented Sep 27, 2024

turkenf commented Sep 27, 2024

turkenf commented Sep 27, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 1, 2024

turkenf commented Oct 2, 2024 • edited Loading

turkenf commented Oct 2, 2024

turkenf commented Oct 2, 2024

turkenf commented Oct 2, 2024

turkenf commented Oct 2, 2024

mergenci left a comment

Choose a reason for hiding this comment

mergenci commented Oct 4, 2024

mergenci commented Oct 4, 2024

mergenci commented Oct 4, 2024

mergenci left a comment • edited Loading

Choose a reason for hiding this comment

turkenf commented Sep 24, 2024 •

edited by mergenci

Loading

turkenf commented Oct 2, 2024 •

edited

Loading

mergenci left a comment •

edited

Loading